Open
Conversation
danielhjacobs
added
llm
SuchAFuriousDeath
suggested changes
Mar 12, 2026
Implement SecureSocket AS3 class and runtime support: add SecureSocket AS file and native bindings, integrate TLS certificate status into SocketObject and Sockets manager, add NavigatorBackend secure connect path and frontend-utils TLS support, update Cargo manifests, and add tests + fixtures for secure socket behavior. Co-authored-by: Claude <claude@anthropic.com>
Collaborator
|
Have you found any content that depends on this? IMO we probably shouldn't be adding such a large amount of code to support something if nothing uses it. |
Contributor
Author
I was planning to use it perhaps for AQWorlds instead of depending on https://github.com/timkurvers/as3-crypto (AS3Crypto from Hurlant, their TLSEngine/TLSSocket classes in particular) in addition with WebSockets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
flash.net.SecureSocketclass for AVM2, enabling support for encrypted socket communication within Ruffle. The contents of this pull request were substantially written using Claude Opus 4.6. I've reviewed to the best of my ability.Changes
AVM2 (
core)flash.net.SecureSocketActionScript class definition (SecureSocket.as).SocketObjectandSocketsmanager to support TLS handshake and certificate tracking.Backends (
core,frontend-utils)NavigatorBackendwithconnect_securefunctionality.rustlsintofrontend-utilsto provide cross-platform TLS support (web and desktop).Testing (
tests)mockettest utility to support TLS server simulation.avm2/secure_socket_connectto verify the end-to-end secure connection flow, including handshake and data exchange.